xuyangzhong commented on PR #27828: URL: https://github.com/apache/flink/pull/27828#issuecomment-4132044933
> @xuyangzhong Overall looks good! I left some minor comments there. > > Btw, can you add extra boundary tests, e.g., using empty dimension table / null value as join key. Sure. Tests with `1. join keys contain null 2. empty table` are added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
