dylanhz commented on PR #27821: URL: https://github.com/apache/flink/pull/27821#issuecomment-4131346487
> And for the AND_AGG and OR_AGG with retraction functions, we'd better document the perf cliff when dealing large bitmaps (use non-heap statebackend), WDYT? @lincoln-lil Thanks for the review! Here's a summary of updates per commit: - **Commit 1 (hotfix):** Made `RoaringBitmapData.toRoaringBitmapData()` public for use by aggregate functions - **Commit 3 (AND/OR/XOR_AGG):** Replaced direct `(RoaringBitmapData)` casts with `RoaringBitmapData.toRoaringBitmapData()`; added performance note for `BITMAP_AND_AGG` and `BITMAP_OR_AGG` retraction variants in docs, Table API, and PyFlink API - **Commit 4 (cardinality):** Same performance note added for `BITMAP_AND_CARDINALITY_AGG` and `BITMAP_OR_CARDINALITY_AGG` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
