davidradl commented on code in PR #27814:
URL: https://github.com/apache/flink/pull/27814#discussion_r2989639946
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackendSnapshotStrategy.java:
##########
@@ -236,6 +251,20 @@ public SnapshotResultSupplier<OperatorStateHandle>
asyncSnapshot(
};
}
+ private boolean hasOnlyEmptyOperatorListStates(
+ Map<String, PartitionableListState<?>>
registeredOperatorStatesDeepCopies) {
+ if (registeredOperatorStatesDeepCopies.isEmpty()) {
+ return false;
+ }
+
+ for (PartitionableListState<?> listState :
registeredOperatorStatesDeepCopies.values()) {
Review Comment:
I see the method is called `private boolean
hasOnlyEmptyOperatorListStates(`
I am not sure what the test for emptiness is. The only thing I see is
`listState == null`,
but `if listState == null` then we return `false`.
What am I missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
