lihaosky commented on code in PR #27462:
URL: https://github.com/apache/flink/pull/27462#discussion_r2986021668
##########
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/CommonTestUtils.java:
##########
@@ -70,6 +71,9 @@ public class CommonTestUtils {
private static final long RETRY_INTERVAL = 100L;
+ /** Default timeout for waiting on tasks to reach running state. */
+ public static final Duration DEFAULT_WAIT_FOR_TASKS_TIMEOUT =
Duration.ofMinutes(5);
Review Comment:
I think adding timeout for wait until a condition isn't a bad idea than let
it hanging forever. Just the duration needs to be carefully chosen not to
timeout too soon. Similar to https://github.com/apache/flink/pull/27767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
