gyfora opened a new pull request, #1074:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1074
## What is the purpose of the change
This PR fixes a few outstanding cornercases during session job deletion that
may lead to blocking and NPEs at the moment.
- Never block deletion if session cluster no longer exists
- Explicitly check sessionReady before cancelling jobs to avoid NPE
- Do not block job deletion when a session cluster is being deleted (to
avoid deletion deadlocks)
- Do not block job deletion if session cluster unhealthy and HA not enabled
as jobs won't restart automatically.
This PR still preserves the intended overall behavior that we only allow
session job deletion to succeed when we can guarantee that the job is no longer
running (and won't restart itself).
## Verifying this change
Unit tests, manually tested on cluster env
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: yes
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
