lincoln-lil commented on code in PR #27734:
URL: https://github.com/apache/flink/pull/27734#discussion_r2909762517
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalDeltaJoin.java:
##########
@@ -152,24 +197,308 @@ protected RelDataType deriveRowType() {
}
@Override
- public com.google.common.collect.ImmutableList<RelHint> getHints() {
- return hints;
+ public RelWriter explainTerms(RelWriter pw) {
+ pw =
+ pw.input("left", left)
+ .input("right", right)
+ .item("joinType",
JoinTypeUtil.getFlinkJoinType(joinType).toString())
+ .item(
+ "where",
+ getExpressionString(
+ condition,
+ JavaScalaConversionUtil.toScala(
+
this.getRowType().getFieldNames())
+ .toList(),
+
JavaScalaConversionUtil.toScala(Optional.empty()),
+
RelExplainUtil.preferExpressionFormat(pw),
+
RelExplainUtil.preferExpressionDetail(pw)));
+
+ switch (deltaJoinPattern) {
+ case BINARY:
+ break;
Review Comment:
My suggestion is the unified format has better structure and readability, as
long as it doesn't cause the digest content to become excessively bloated or
difficult to read, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
