X-czh commented on PR #26881: URL: https://github.com/apache/flink/pull/26881#issuecomment-4028056963
@RocMarshal Thanks for the suggestion. The `hasToString` expr is indeed more elegant. However, I think `isEqualTo(1)` is more readable than `isOne` in this case. We are just asserting a field has the desired value which is randomly picked by the developer, and number 1/0 has no special meaning here (unlike for example, we are asserting sth happens exactly once) and I find it more readable to have the same assertion format as other values like 2. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
