davidradl commented on code in PR #28:
URL:
https://github.com/apache/flink-connector-http/pull/28#discussion_r2905630595
##########
docs/content.zh/docs/connectors/datastream/http.md:
##########
@@ -92,8 +98,10 @@ HttpSink.<String>builder()
.build();
```
-### Single submission mode
-In this mode every processed event is submitted as individual HTTP POST/PUT
request.
+In this example, the default `sink.batch.max-size` of 500 is used. When Flink
flushes 500 records, the HTTP Sink splits them into 10 HTTP POST requests (50
records each).
Review Comment:
I think the single submission mode, is does as the original text said. The
`PerRequestSubmitter` class does not look at the batching configuration. This
is all done in the `BatchRequestSubmitter ` class.
I suggest we add what the config parameter is that means we are in Single
submission mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
