lvyanquan commented on PR #4294: URL: https://github.com/apache/flink-cdc/pull/4294#issuecomment-4021394972
Hi @macdoor. I reviewed your code and found an issue: we cannot directly compile and test the entire project using the flink2 profile (even though you verified the feasibility of the changes in a Flink session). This raises concerns about the reliability of the code. I picked the key changes from your code (I will add you as a collaborator), and on that basis, I implemented it so that it can compile and test with both Flink 1.20 and Flink 2.2 (by specifying the flink2 profile). I've added the corresponding tests in CI. Perhaps @macdoor and @yuxiqian can continue reviewing the code now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
