rionmonster commented on code in PR #27728:
URL: https://github.com/apache/flink/pull/27728#discussion_r2893760960
##########
flink-python/pyflink/table/catalog.py:
##########
@@ -1251,6 +1251,21 @@ def get_object_name(self) -> str:
def get_full_name(self) -> str:
return self._j_object_path.getFullName()
+ def compare_to(self, other: 'ObjectPath') -> int:
Review Comment:
We may want to consider adding a series of tests for these operations to the
existing `CatalogTestBase` if anything just to exercise these happy paths and
any potential edge cases (e.g. comparisons against non-`ObjectPath` objects
such as `someObjectPath < 42`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
