tomncooper commented on code in PR #53:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/53#discussion_r2891123700
##########
.github/workflows/ci.yml:
##########
@@ -113,6 +113,10 @@ jobs:
if: ${{ inputs.optional_maven_profiles }}
run: echo "MVN_COMMON_OPTIONS=${MVN_COMMON_OPTIONS} -P ${{
inputs.optional_maven_profiles }}" >> $GITHUB_ENV
+ - name: "Set java11 compile target if required"
+ if: ${{ matrix.jdk == 11 }}
Review Comment:
@ferenc-csaky WDYT? Would it be better to create a java 21 target profile
and have each jvm version use the appropriate profile. If so we could add the
profile name to the matrix and pass it as an arg to the GH action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
