wenjin272 commented on code in PR #548:
URL: https://github.com/apache/flink-agents/pull/548#discussion_r2889180771
##########
runtime/src/main/java/org/apache/flink/agents/runtime/operator/ActionExecutionOperator.java:
##########
@@ -723,8 +731,8 @@ public void close() throws Exception {
if (actionStateStore != null) {
actionStateStore.close();
}
- if (runnerContext != null) {
- runnerContext.close();
+ if (resourceCache != null) {
+ resourceCache.close();
Review Comment:
I investigated the cross-language test issues locally and found that
`resourceCache.close()` must be called before `pythonInterpreter.close()`.
After moving it to the very beginning of the `close()` method, the tests passed
successfully.
The issue didn't appear earlier because I missed something while resolving a
merge conflict, which caused runnerContext to be closed twice in the `close()`
method. In reality, only the first close operation took effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
