xintongsong commented on code in PR #557:
URL: https://github.com/apache/flink-agents/pull/557#discussion_r2888566690
##########
dist/flink-1.20/pom.xml:
##########
@@ -159,6 +159,49 @@ under the License.
<createDependencyReducedPom>false</createDependencyReducedPom>
</configuration>
</execution>
+ <!-- Build thin jar for Python wheel (only flink-agents
code) -->
+ <execution>
+ <id>shade-flink-agents-thin</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadeTestJar>false</shadeTestJar>
+
<shadedArtifactAttached>false</shadedArtifactAttached>
+
<finalName>${project.artifactId}-${project.version}-thin</finalName>
+ <!-- Only include flink-agents artifacts -->
+ <artifactSet>
+ <includes>
+
<include>org.apache.flink:flink-agents-*</include>
+ </includes>
+ </artifactSet>
+ <filters>
+ <!-- Only include flink-agents classes -->
+ <filter>
+ <artifact>*:*</artifact>
+ <includes>
+
<include>org/apache/flink/agents/**</include>
+ </includes>
+ </filter>
+ <!-- Exclude the conflict class in runtime
module for flink-1.20 -->
+ <filter>
+
<artifact>org.apache.flink:flink-agents-runtime</artifact>
+ <excludes>
+
<exclude>org/apache/flink/agents/runtime/operator/OperatorUtils.class</exclude>
Review Comment:
Do we really need this excluding? I think classes of the current module
should have higher priority compared to classes introduced from dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
