Izeren commented on code in PR #27719:
URL: https://github.com/apache/flink/pull/27719#discussion_r2879687366
##########
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java:
##########
@@ -67,17 +67,23 @@ class ExecutionGraphRestartTest {
private static final int NUM_TASKS = 31;
@RegisterExtension
- static final TestExecutorExtension<ScheduledExecutorService>
EXECUTOR_RESOURCE =
- TestingUtils.defaultExecutorExtension();
+ static final TestExecutorExtension<ScheduledExecutorService>
EXECUTOR_EXTENSION =
+ TestingUtils.jmAsyncThreadExecutorExtension();
- private static final ComponentMainThreadExecutor mainThreadExecutor =
- ComponentMainThreadExecutorServiceAdapter.forMainThread();
+ @RegisterExtension
+ static final TestExecutorExtension<ScheduledExecutorService>
JM_MAIN_THREAD_EXECUTOR_EXTENSION =
+ TestingUtils.jmMainThreadExecutorExtension();
+
+ private ComponentMainThreadExecutor mainThreadExecutor;
private ManuallyTriggeredScheduledExecutor taskRestartExecutor;
@BeforeEach
void setUp() {
taskRestartExecutor = new ManuallyTriggeredScheduledExecutor();
+ mainThreadExecutor =
Review Comment:
> Root cause: some operation lines is not scoped in sync logic(we need to
update the related lines to fix the flaky test cases.)
I am not sure I fully understand where race condition in this test coming
from. @RocMarshal, could you please explain where the flow breaks? I will see
if I have time to test it locally tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
