addu390 commented on issue #424: URL: https://github.com/apache/flink-agents/issues/424#issuecomment-3988958433
@xintongsong Thanks for the detailed clarification! I'll close #558, I interpreted the issue differently. But what you explained makes the end-goal clearer. I'll ask/suggest a few design questions before moving to impl. Seems like we are half way there? `Event` has `attributes` (`Map<String, Object>`), Java routing uses class-name (`String`) internally. An Implementation overview: - Make `Event` a concrete class (currently `abstract`) with a `type` field. - Use `event.getType()` instead of class name (defaults to class-name). - `@Action` (In java and python), accepts `String` along-side class types. - `JSON` for Serde. - Creation APIs: Builder pattern would be a nice too. In python, must haves would be `Kwargs` and `**my_dict`. But all of these are easy to extend to later on. Questions: - Good to re-use `attributes` in `Event` for this purpose? Unless it was meant to be for something else. - Any concerns with using `JSON` for Serde? Happy to draft a more detailed design if that would be helpful before starting the implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
