davidradl commented on code in PR #27722:
URL: https://github.com/apache/flink/pull/27722#discussion_r2872649018
##########
tools/ci/log4j.properties:
##########
@@ -64,21 +64,15 @@ logger.zookeeper.name = org.apache.zookeeper
logger.zookeeper.level = INFO
logger.zookeeper.additivity = false
logger.zookeeper.appenderRef.zk.ref = ZooKeeperServerAppender
-# FinalRequestProcessor in DEBUG mode enables us to see requests being
processed by the ZK server
logger.zookeeper_FinalRequestProcessor.name =
org.apache.zookeeper.server.FinalRequestProcessor
-logger.zookeeper_FinalRequestProcessor.level = DEBUG
+logger.zookeeper_FinalRequestProcessor.level = INFO
logger.zookeeper_FinalRequestProcessor.additivity = false
logger.zookeeper_FinalRequestProcessor.appenderRef.zk.ref =
ZooKeeperServerAppender
logger.shaded_zookeeper.name = org.apache.flink.shaded.zookeeper3
logger.shaded_zookeeper.level = INFO
logger.shaded_zookeeper.additivity = false
logger.shaded_zookeeper.appenderRef.zk.ref = ZooKeeperClientAppender
-logger.leaderretrieval.name = org.apache.flink.runtime.leaderretrieval
Review Comment:
I looked at the code in this package - the `log.debug`s in`
ZooKeeperLeaderRetrievalDriver` are not enclosed with `if
(LOG.isDebugEnabled()) { `. I suggest adding `if (LOG.isDebugEnabled()) { `
around the 3 log.debugs. The one I am most concerned about is
[https://github.com/apache/flink/blob/861845ae950cb6cf7187d54e67271485763d576c/flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/ZooKeeperLeaderRetrievalDriver.java#L107](https://github.com/apache/flink/blob/861845ae950cb6cf7187d54e67271485763d576c/flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/ZooKeeperLeaderRetrievalDriver.java#L107)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
