Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/3143#discussion_r96638478
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRocksDBState.java
---
@@ -132,55 +132,95 @@ public void setCurrentNamespace(N namespace) {
namespaceSerializer);
int keyGroup = KeyGroupRangeAssignment.assignToKeyGroup(des.f0,
backend.getNumberOfKeyGroups());
- writeKeyWithGroupAndNamespace(keyGroup, des.f0, des.f1);
- return backend.db.get(columnFamily,
keySerializationStream.toByteArray());
+
+ // we cannot reuse the keySerializationStream member since this
method
+ // is called concurrently to the other ones and it may thus
contain garbage
+ ByteArrayOutputStreamWithPos tmpKeySerializationStream =
--- End diff --
yes, I saw very long lines here and there but imho 120 is quite long and
affects readability as well - so does wrapping lines to some extend... I will
go up to 90 instead
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
