ldadima commented on PR #27508: URL: https://github.com/apache/flink/pull/27508#issuecomment-3935116865
> Hey @ldadima, thanks for both commits, it makes it easier to review. I think the [second approach](https://github.com/apache/flink/pull/27508/changes/609492c0fbb4025ef53436384e669187a1aa21ff) is cleaner. With it, we're avoiding creating a serializer in every call Hi, @gustavodemorais Okay, let's keep 2nd solution . But I'd like to point out that the updated 1st solution doesn't create any serializers at all. This solution reuses the code from the _RowDataSerializer#toBinaryRow()_: creating an empty BinaryRowData and filling it using a BinaryWriter. This solution is more optimal—we create fewer unnecessary objects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
