[ https://issues.apache.org/jira/browse/FLINK-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fabian Hueske closed FLINK-5518. -------------------------------- Resolution: Fixed Fix Version/s: 1.1.5 1.3.0 1.2.0 Fixed for 1.3.0 with ece899a9f33b3fe4aa35d6cc66c43053170e631f Fixed for 1.2.0 with aad8d253c9f7dd33a63310353cbe132cd4900c6b Fixed for 1.1.5 with 214c188d7fffd66a43325eff392f12e8f3421fab > HadoopInputFormat throws NPE when close() is called before open() > ----------------------------------------------------------------- > > Key: FLINK-5518 > URL: https://issues.apache.org/jira/browse/FLINK-5518 > Project: Flink > Issue Type: Bug > Components: Batch Connectors and Input/Output Formats > Affects Versions: 1.2.0, 1.1.4 > Reporter: Jakub Havlik > Assignee: Jakub Havlik > Labels: beginner, easyfix, newbie > Fix For: 1.2.0, 1.3.0, 1.1.5 > > > When developing a simple Flink applications reading ORC files it crashes with > NullPointerException when number of instances/executor threads is higher then > the number of files because it is trying to close a HadoopInputFormat which > is trying to close RecordReader which was not yet initialized as there is no > file for which it should have been opened. The issue is caused when > {code:java} > public void run(SourceContext<OUT> ctx) throws Exception { > try { > ... > while (isRunning) { > format.open(splitIterator.next()); > ... > } finally { > format.close(); > ... > } > {code} > in file {{InputFormatSourceFunction.java}} which calls > {code:java} > public void close() throws IOException { > // enforce sequential close() calls > synchronized (CLOSE_MUTEX) { > this.recordReader.close(); > } > } > {code} > from {{HadoopInputFormatBase.java}}. > As there is just this one implementation of the {{close()}} method it may be > enough just to add a null check for the {{this.recordReader}} in there. -- This message was sent by Atlassian JIRA (v6.3.4#6332)