zhuzhurk commented on code in PR #27475:
URL: https://github.com/apache/flink/pull/27475#discussion_r2745096712
##########
flink-clients/src/main/java/org/apache/flink/client/deployment/application/executors/EmbeddedExecutor.java:
##########
@@ -110,14 +111,17 @@ public CompletableFuture<JobClient> execute(
throws Exception {
checkNotNull(pipeline);
checkNotNull(configuration);
+ checkState(pipeline instanceof StreamGraph);
+
+ StreamGraph streamGraph = (StreamGraph) pipeline;
final Optional<JobID> optJobId =
configuration
.getOptional(PipelineOptionsInternal.PIPELINE_FIXED_JOB_ID)
.map(JobID::fromHexString);
- if (optJobId.isPresent() && submittedJobIds.contains(optJobId.get())) {
- return getJobClientFuture(optJobId.get(), userCodeClassloader);
+ if (optJobId.isPresent() &&
submittedJobIds.contains(streamGraph.getJobID())) {
Review Comment:
Could you explain in which case this would happen?
##########
flink-clients/src/main/java/org/apache/flink/client/program/StreamContextEnvironment.java:
##########
@@ -134,6 +142,19 @@ public StreamContextEnvironment(
this.programConfigEnabled = programConfigEnabled;
this.programConfigWildcards = programConfigWildcards;
this.applicationId = applicationId;
+ this.jobIdManager = createJobIdManager(configuration,
allRecoveredJobInfos);
+ }
+
+ private JobIdManager createJobIdManager(
+ Configuration configuration, Collection<JobInfo>
allRecoveredJobInfos) {
+ Optional<String> optionalBaseJobId =
+
configuration.getOptional(PipelineOptionsInternal.PIPELINE_FIXED_JOB_ID);
+ if (optionalBaseJobId.isEmpty()) {
Review Comment:
Could you add some comments to explain in which case this may happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
