yuxiqian commented on code in PR #4238:
URL: https://github.com/apache/flink-cdc/pull/4238#discussion_r2732177183
##########
docs/content/docs/developer-guide/contribute-to-flink-cdc.md:
##########
Review Comment:
Could you please modify
`content.zh/docs/developer-guide/contribute-to-flink-cdc.md`, too?
##########
flink-cdc-e2e-tests/flink-cdc-source-e2e-tests/src/test/java/org/apache/flink/cdc/connectors/tests/MongoE2eITCase.java:
##########
@@ -123,7 +113,7 @@ public void after() {
})
void testMongoDbCDC(String mongoVersion, boolean parallelismSnapshot,
boolean scanFullChangelog)
throws Exception {
- setup(mongoVersion, parallelismSnapshot, scanFullChangelog);
+ setup(mongoVersion, scanFullChangelog);
Review Comment:
Seems a little strange to modify this. Should we remove `mongoVersion` from
ParameterizedTest CsvSource, and keep the `parallelismSnapshot` variant?
```java
@ParameterizedTest(name = "boolean parallelismSnapshot: {0},
scanFullChangelog: {1}")
@CsvSource({
"true, true",
"true, false",
"false, true",
"false, false"
})
void testMongoDbCDC(boolean parallelismSnapshot, boolean scanFullChangelog) {
...
```
##########
docs/content/docs/developer-guide/contribute-to-flink-cdc.md:
##########
@@ -51,6 +51,8 @@ Flink CDC is maintained, improved, and extended by code
contributions of volunte
Please feel free to ask questions at any time. Either send a mail to the Dev
mailing list or comment on the issue you are working on.
+Flink CDC use jdk11 as the baseline version. Please make sure your development
environment is set up correctly.
Review Comment:
```suggestion
Flink CDC uses JDK 11 as the baseline version. Please make sure your
development environment is set up correctly.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
