[jira] [Commented] (FLINK-5518) HadoopInputFormat throws NPE when close() is called before open()

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825845#comment-15825845
 ] 

ASF GitHub Bot commented on FLINK-5518:
---------------------------------------

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3133
  
    Thanks for the PR @jakubhavlik.
    
    The fix looks good. Can you add a `testCloseWithoutOpen()` method to 
`org.apache.flink.api.java.hadoop.mapred.HadoopInputFormatTest` and 
`org.apache.flink.api.java.hadoop.mapreduce.HadoopInputFormatTest` to guard 
this fix?
    
    Occasionally builds fail due to timeouts. That's nothing to worry about. 
I'll run the tests again before merging.
    
    Thank you.


> HadoopInputFormat throws NPE when close() is called before open()
> -----------------------------------------------------------------
>
>                 Key: FLINK-5518
>                 URL: https://issues.apache.org/jira/browse/FLINK-5518
>             Project: Flink
>          Issue Type: Bug
>          Components: Batch Connectors and Input/Output Formats
>    Affects Versions: 1.2.0, 1.1.4
>            Reporter: Jakub Havlik
>            Assignee: Jakub Havlik
>              Labels: beginner, easyfix, newbie
>
> When developing a simple Flink applications reading ORC files it crashes with 
> NullPointerException when number of instances/executor threads is higher then 
> the number of files because it is trying to close a HadoopInputFormat which 
> is trying to close RecordReader which was not yet initialized as there is no 
> file for which it should have been opened. The issue is caused when
> {code:java}
> public void run(SourceContext<OUT> ctx) throws Exception {
>     try {
> ...
>         while (isRunning) {
>           format.open(splitIterator.next());
> ...
>     } finally {
>       format.close();
> ...
>     }
> {code}
> in file {{InputFormatSourceFunction.java}} which calls
> {code:java}
> public void close() throws IOException {
>     // enforce sequential close() calls
>     synchronized (CLOSE_MUTEX) {
>         this.recordReader.close();
>     }
> }
> {code}
> from {{HadoopInputFormatBase.java}}.
> As there is just this one implementation of the {{close()}} method it may be 
> enough just to add a null check for the {{this.recordReader}} in there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)