[
https://issues.apache.org/jira/browse/FLINK-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825642#comment-15825642
]
Jakub Havlik edited comment on FLINK-5518 at 1/17/17 8:43 AM:
--------------------------------------------------------------
[~fhueske] Pull request is created:
https://github.com/apache/flink/pull/3133/files . Please take a loot at it if
it complies to the Flink coding standards.
was (Author: havlikj):
[~fhueske] I already have it locally and I'm waiting for the tests to pass so I
think I can fix it.
> HadoopInputFormat throws NPE when close() is called before open()
> -----------------------------------------------------------------
>
> Key: FLINK-5518
> URL: https://issues.apache.org/jira/browse/FLINK-5518
> Project: Flink
> Issue Type: Bug
> Components: Batch Connectors and Input/Output Formats
> Affects Versions: 1.2.0, 1.1.4
> Reporter: Jakub Havlik
> Labels: beginner, easyfix, newbie
>
> When developing a simple Flink applications reading ORC files it crashes with
> NullPointerException when number of instances/executor threads is higher then
> the number of files because it is trying to close a HadoopInputFormat which
> is trying to close RecordReader which was not yet initialized as there is no
> file for which it should have been opened. The issue is caused when
> {code:java}
> public void run(SourceContext<OUT> ctx) throws Exception {
> try {
> ...
> while (isRunning) {
> format.open(splitIterator.next());
> ...
> } finally {
> format.close();
> ...
> }
> {code}
> in file {{InputFormatSourceFunction.java}} which calls
> {code:java}
> public void close() throws IOException {
> // enforce sequential close() calls
> synchronized (CLOSE_MUTEX) {
> this.recordReader.close();
> }
> }
> {code}
> from {{HadoopInputFormatBase.java}}.
> As there is just this one implementation of the {{close()}} method it may be
> enough just to add a null check for the {{this.recordReader}} in there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
