lvyanquan commented on code in PR #4192:
URL: https://github.com/apache/flink-cdc/pull/4192#discussion_r2675278136
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-iceberg/src/test/java/org/apache/flink/cdc/connectors/iceberg/sink/IcebergDataSinkFactoryTest.java:
##########
@@ -92,4 +108,77 @@ void testPrefixRequireOption() {
conf, conf,
Thread.currentThread().getContextClassLoader()));
Assertions.assertThat(dataSink).isInstanceOf(IcebergDataSink.class);
}
+
+ @Test
+ public void testPartitionOption() {
Review Comment:
We should also add a test for writing record to Iceberg table to verify that
IcebergWriter worked as expected.
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-iceberg/src/main/java/org/apache/flink/cdc/connectors/iceberg/sink/IcebergDataSinkOptions.java:
##########
@@ -51,7 +51,8 @@ public class IcebergDataSinkOptions {
.withDescription(
"Partition keys for each partitioned table, allow
setting multiple primary keys for multiTables. "
+ "Tables are separated by ';', and
partition keys are separated by ','. "
- + "For example, we can set partition.key
of two tables by 'testdb.table1:id1,id2;testdb.table2:name'.");
+ + "For example, we can set partition.key
of two tables by 'testdb.table1:id1,id2;testdb.table2:name'."
+ + "For partition transforms, we can set
partition.key by
'testdb.table1:truncate[10](id);testdb.table2:day(create_time)'.");
Review Comment:
Nit: list all supported partition transforms.
And please update the related documents too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
