yuxiqian commented on code in PR #4212:
URL: https://github.com/apache/flink-cdc/pull/4212#discussion_r2666817804


##########
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/pipeline/PipelineOptions.java:
##########
@@ -72,6 +72,22 @@ public class PipelineOptions {
                                                             "EXCEPTION: Throw 
an exception to terminate the sync pipeline.")))
                                     .build());
 
+    public static final ConfigOption<String> PIPELINE_ROUTE_MODE =
+            ConfigOptions.key("route-mode")
+                    .stringType()

Review Comment:
   Just checked other enumType options and most of them require keys in 
SCREAMING_SNAKE_CASE.
   
   We may modify `ConfigurationUtils#convertToEnum` to allow barbeque namings 
for enum values later in another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to