davidradl commented on code in PR #27386:
URL: https://github.com/apache/flink/pull/27386#discussion_r2664237275
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/operator/AlignedWindowTableFunctionOperator.java:
##########
@@ -46,8 +46,9 @@ public class AlignedWindowTableFunctionOperator extends
WindowTableFunctionOpera
public AlignedWindowTableFunctionOperator(
GroupWindowAssigner<TimeWindow> windowAssigner,
int rowtimeIndex,
+ int timestampPrecision,
ZoneId shiftTimeZone) {
- super(windowAssigner, rowtimeIndex, shiftTimeZone);
+ super(windowAssigner, rowtimeIndex, timestampPrecision, shiftTimeZone);
Review Comment:
I think it would be cleaner to keep the original method signature, and call
the `super(windowAssigner, rowtimeIndex,shiftTimeZone);` The default then live
in the WindowTableFunctionOperatorBase, rather than being specified in all the
callers
The callers that need to pass the precision can use the new method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
