AHeise commented on code in PR #26975:
URL: https://github.com/apache/flink/pull/26975#discussion_r2663946257


##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSource.java:
##########
@@ -155,10 +157,12 @@ public SimpleVersionedSerializer<HybridSourceSplit> 
getSplitSerializer() {
      *
      * <p>Currently only the previous enumerator is exposed. The context 
interface allows for
      * backward compatible extension, i.e. additional information about the 
previous source can be
-     * supplied in the future.
+     * supplied in the future. However, since enumerator instances are not by 
default serializable
+     * or checkpointed, one must handle null returns here.

Review Comment:
   Let's keep the original method and instead add a javadoc to the method 
describing when the null is returned.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to