snuyanzin commented on code in PR #27381: URL: https://github.com/apache/flink/pull/27381#discussion_r2662316472
########## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/table/SqlAlterTableDrop.java: ########## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.parser.ddl.table; + +import org.apache.flink.sql.parser.SqlUnparseUtils; +import org.apache.flink.sql.parser.ddl.SqlWatermark; +import org.apache.flink.sql.parser.ddl.constraint.SqlTableConstraint; + +import org.apache.calcite.sql.SqlIdentifier; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlNodeList; +import org.apache.calcite.sql.SqlWriter; +import org.apache.calcite.sql.parser.SqlParserPos; + +import javax.annotation.Nullable; + +import java.util.List; + +/** + * SqlNode to describe ALTER TABLE [IF EXISTS] table_name MODIFY column/constraint/watermark clause. + * + * <p>Example: DDL like the below for modify column/constraint/watermark. + * + * <pre>{@code + * -- modify single column + * ALTER TABLE mytable MODIFY new_column STRING COMMENT 'new_column docs'; + * + * -- modify multiple columns, constraint, and watermark + * ALTER TABLE mytable MODIFY ( + * log_ts STRING COMMENT 'log timestamp string' FIRST, + * ts AS TO_TIMESTAMP(log_ts) AFTER log_ts, + * col_meta int metadata from 'mk1' virtual AFTER col_b, + * PRIMARY KEY (id) NOT ENFORCED, + * WATERMARK FOR ts AS ts - INTERVAL '3' SECOND + * ); + * }</pre> + */ +public abstract class SqlAlterTableDrop extends SqlAlterTableSchema { + + public SqlAlterTableDrop( + SqlParserPos pos, + SqlIdentifier tableName, + SqlNodeList modifiedColumns, + List<SqlTableConstraint> constraints, + @Nullable SqlWatermark watermark, + boolean ifTableExists) { + super(pos, tableName, modifiedColumns, constraints, watermark, ifTableExists); + } + + public SqlAlterTableDrop(SqlParserPos pos, SqlIdentifier tableName, boolean ifTableExists) { + super(pos, tableName, SqlNodeList.EMPTY, List.of(), null, ifTableExists); + } + + protected abstract void unparseDropOperation(SqlWriter writer, int leftPrec, int rightPrec); + + @Override + public List<SqlNode> getOperandList() { + return List.of(tableIdentifier); + } + + @Override + protected String getAlterOperation() { + return "DROP"; + } + + @Override + public void unparseAlterOperation(SqlWriter writer, int leftPrec, int rightPrec) { + super.unparseAlterOperation(writer, leftPrec, rightPrec); + unparseDropOperation(writer, leftPrec, rightPrec); + } + + /** ALTER TABLE [IF EXISTS ][catalog_name.][db_name.]table_name DROP PRIMARY KEY. */ + public static class SqlAlterTableDropPrimaryKey extends SqlAlterTableDrop { + + public SqlAlterTableDropPrimaryKey( + SqlParserPos pos, SqlIdentifier tableName, boolean ifTableExists) { + super(pos, tableName, ifTableExists); + } + + @Override + protected void unparseDropOperation(SqlWriter writer, int leftPrec, int rightPrec) { + writer.keyword("PRIMARY KEY"); + } + } + + /** + * ALTER TABLE [IF EXISTS ][catalog_name.][db_name.]table_name DROP CONSTRAINT constraint_name. + */ + public static class SqlAlterTableDropConstraint extends SqlAlterTableDrop { + private final SqlIdentifier constraintName; + + public SqlAlterTableDropConstraint( + SqlParserPos pos, + SqlIdentifier tableName, + SqlIdentifier constraintName, + boolean ifTableExists) { + super(pos, tableName, ifTableExists); + this.constraintName = constraintName; + } + + public SqlIdentifier getConstraintName() { + return constraintName; + } + + @Override + protected void unparseDropOperation(SqlWriter writer, int leftPrec, int rightPrec) { + writer.keyword("CONSTRAINT"); + constraintName.unparse(writer, leftPrec, rightPrec); + } + } + + /** ALTER TABLE [IF EXISTS ][catalog_name.][db_name.]table_name DROP PRIMARY KEY. */ Review Comment: thanks, updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
