och5351 commented on code in PR #183:
URL:
https://github.com/apache/flink-connector-jdbc/pull/183#discussion_r2659725023
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/database/JdbcFactory.java:
##########
@@ -64,6 +64,13 @@ default JdbcDialect createDialect(String compatibleMode) {
"Not supported option 'compatible-mode' with value: " +
compatibleMode);
}
+ JdbcCatalog createCatalog(
Review Comment:
Thanks for the follow-up review, @RocMarshal.
You’re right—the method can be removed, so I’ve deleted it.
I also updated the commit message to match the PR title.
Could you please take another look at the latest commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
