rkhachatryan commented on code in PR #27337:
URL: https://github.com/apache/flink/pull/27337#discussion_r2619820749


##########
flink-metrics/flink-metrics-otel/src/main/java/org/apache/flink/traces/otel/OpenTelemetryTraceReporter.java:
##########
@@ -70,10 +70,14 @@ public void open(MetricConfig metricConfig) {
 
     @Override
     public void close() {
-        spanProcessor.forceFlush();
-        spanProcessor.close();
-        spanExporter.flush();
-        spanExporter.close();
+        if (spanProcessor != null) {

Review Comment:
   According to the code, `spanProcessor` and `spanExporter` must be either 
null or not null both.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to