davidradl commented on code in PR #27331:
URL: https://github.com/apache/flink/pull/27331#discussion_r2614785557
##########
flink-python/pyflink/datastream/formats/tests/test_csv.py:
##########
@@ -344,6 +350,24 @@ def _check_csv_use_header_results(test, results):
test.assertEqual(row['number'], 123)
+def _create_csv_default_null_value_schema_and_lines() -> Tuple[CsvSchema,
List[str]]:
+ schema = CsvSchema.builder() \
+ .add_string_column('string') \
+ .add_number_column('number') \
+ .set_null_value('') \
Review Comment:
Looks good. Some testing suggestions:
I would test a test with .set_null_value(), set the default? If so we
should test that
I also suggest a test specifying that a non default literal for null works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
