RocMarshal commented on code in PR #183:
URL:
https://github.com/apache/flink-connector-jdbc/pull/183#discussion_r2612565574
##########
flink-connector-jdbc-mysql/src/test/java/org/apache/flink/connector/jdbc/mysql/database/MySqlFactoryDefaultDatabaseSameTest.java:
##########
@@ -0,0 +1,65 @@
+package org.apache.flink.connector.jdbc.mysql.database;
Review Comment:
ditto
##########
flink-connector-jdbc-mysql/src/test/java/org/apache/flink/connector/jdbc/mysql/database/MySqlFactoryTest.java:
##########
@@ -0,0 +1,68 @@
+package org.apache.flink.connector.jdbc.mysql.database;
Review Comment:
ditto
##########
flink-connector-jdbc-cratedb/src/test/java/org/apache/flink/connector/jdbc/cratedb/database/CrateDBFactoryDefaultDatabaseNullTest.java:
##########
@@ -0,0 +1,62 @@
+package org.apache.flink.connector.jdbc.cratedb.database;
Review Comment:
missing License header.
##########
flink-connector-jdbc-oceanbase/src/test/java/org/apache/flink/connector/jdbc/oceanbase/database/OceanBaseFactoryDefaultDatabaseNullTest.java:
##########
@@ -0,0 +1,62 @@
+package org.apache.flink.connector.jdbc.oceanbase.database;
+
+import org.apache.flink.connector.jdbc.core.database.JdbcFactoryLoader;
+import org.apache.flink.connector.jdbc.core.database.catalog.JdbcCatalog;
+import
org.apache.flink.connector.jdbc.core.database.catalog.factory.JdbcCatalogFactoryOptions;
+import org.apache.flink.connector.jdbc.oceanbase.OceanBaseMysqlTestBase;
+import
org.apache.flink.connector.jdbc.oceanbase.database.catalog.OceanBaseCatalog;
+import org.apache.flink.table.catalog.Catalog;
+import org.apache.flink.table.catalog.CommonCatalogOptions;
+import org.apache.flink.table.factories.FactoryUtil;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+public class OceanBaseFactoryDefaultDatabaseNullTest implements
OceanBaseMysqlTestBase {
Review Comment:
BTW, It would be better add the comments for the new introduced test class.
##########
flink-connector-jdbc-oceanbase/src/test/java/org/apache/flink/connector/jdbc/oceanbase/database/OceanBaseFactoryDefaultDatabaseNullTest.java:
##########
@@ -0,0 +1,62 @@
+package org.apache.flink.connector.jdbc.oceanbase.database;
Review Comment:
ditto.
##########
flink-connector-jdbc-oceanbase/src/test/java/org/apache/flink/connector/jdbc/oceanbase/database/OceanBaseFactoryTest.java:
##########
@@ -0,0 +1,68 @@
+package org.apache.flink.connector.jdbc.oceanbase.database;
Review Comment:
ditto
##########
flink-connector-jdbc-oceanbase/src/test/java/org/apache/flink/connector/jdbc/oceanbase/database/OceanBaseFactoryDefaultDatabaseSameTest.java:
##########
@@ -0,0 +1,66 @@
+package org.apache.flink.connector.jdbc.oceanbase.database;
Review Comment:
ditto.
##########
flink-connector-jdbc-mysql/src/test/java/org/apache/flink/connector/jdbc/mysql/database/MySqlFactoryDefaultDatabaseNullTest.java:
##########
@@ -0,0 +1,62 @@
+package org.apache.flink.connector.jdbc.mysql.database;
Review Comment:
ditto
##########
flink-connector-jdbc-cratedb/src/test/java/org/apache/flink/connector/jdbc/cratedb/database/CrateDBFactoryDefaultDatabaseSameTest.java:
##########
@@ -0,0 +1,65 @@
+package org.apache.flink.connector.jdbc.cratedb.database;
Review Comment:
ditto
##########
flink-connector-jdbc-cratedb/src/test/java/org/apache/flink/connector/jdbc/cratedb/database/CrateDBFactoryTest.java:
##########
@@ -0,0 +1,68 @@
+package org.apache.flink.connector.jdbc.cratedb.database;
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
