alnzng commented on PR #332:
URL: https://github.com/apache/flink-agents/pull/332#issuecomment-3605320883

   >I think all the vector store provide concept like collection, they may 
called index, namespace or class.
   
   @wenjin272 This was my major concern part since I was not able to verify all 
existing vector stores and we can't predict for new future vector stores. For 
example, Pinecone uses namespace + index to manage its data, namespace which 
seems like a "Collection". However seems it doesn't seem to support 
namespace(medata) update operation, which means below method won't work with 
Pinecone.
    
   ```
   def update_collection(self, name: str, metadata: Dict[str, Any]) -> None:
   ```
   @xintongsong suggestion on adding a new interface for indicating collection 
support seems to be a safe solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to