[ 
https://issues.apache.org/jira/browse/FLINK-38711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18040420#comment-18040420
 ] 

Sergey Nuyanzin edited comment on FLINK-38711 at 11/25/25 11:52 AM:
--------------------------------------------------------------------

Merged as 
[1e0c54ca7dc60ce2462e052c6d122791848297d0|https://github.com/apache/flink/commit/1e0c54ca7dc60ce2462e052c6d122791848297d0]

2.2: 
[2910d729f39d8e706900102707f8850d3a71f112|https://github.com/apache/flink/commit/2910d729f39d8e706900102707f8850d3a71f112]


was (Author: sergey nuyanzin):
Merged as 
[1e0c54ca7dc60ce2462e052c6d122791848297d0|https://github.com/apache/flink/commit/1e0c54ca7dc60ce2462e052c6d122791848297d0]

> LicenseChecker not properly checking included artifacts
> -------------------------------------------------------
>
>                 Key: FLINK-38711
>                 URL: https://issues.apache.org/jira/browse/FLINK-38711
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: BuildSystem / Shaded
>            Reporter: Mate Czagany
>            Assignee: Mate Czagany
>            Priority: Major
>              Labels: pull-request-available
>
> With the upgrade to maven-shade-plugin to 3.6.1, the following PR was also 
> introduced: [https://github.com/apache/maven-shade-plugin/pull/233] 
> This is unfortunate because this log is used by LicenseChecker, and currently 
> LicenseChecker things that absolutely no artifacts are included in any of the 
> output JAR files, giving a false positive test.
> It should be investigated if 3.6.1 can be made to work as it's required by 
> FLINK-38391 to make the build work on JDK 25. 
>  
> These are the CI logs after the maven-shade-plugin upgrade: 
> [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=69766&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=36817]
> These are the CI logs from before the upgrade: 
> [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=69760&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=41781]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to