Myasuka commented on code in PR #27186:
URL: https://github.com/apache/flink/pull/27186#discussion_r2552698008
##########
flink-runtime/src/test/java/org/apache/flink/runtime/util/SerializedThrowableTest.java:
##########
@@ -179,4 +188,62 @@ void testCopySuppressed() {
.isInstanceOf(SerializedThrowable.class)
.hasMessage("java.lang.Exception: suppressed");
}
+
+ @Test
+ void testCyclicSuppressedThrowableSerialized() {
+ SerializedThrowable serializedThrowable = new
SerializedThrowable(mockThrowable());
+ assertThat(serializedThrowable).isNotNull();
+ }
+
+ // Use the repeated test for checking the thread safe and stable.
+ @RepeatedTest(16)
+ void testCyclicSuppressedThrowableConcurrentSerialized() throws
InterruptedException {
Review Comment:
I think this test should add a timeout limit (maybe 5 seconds) as the
original test to used to detect dead lock, which would cause the test never
quit.
##########
flink-runtime/src/test/java/org/apache/flink/runtime/util/SerializedThrowableTest.java:
##########
@@ -179,4 +188,62 @@ void testCopySuppressed() {
.isInstanceOf(SerializedThrowable.class)
.hasMessage("java.lang.Exception: suppressed");
}
+
+ @Test
+ void testCyclicSuppressedThrowableSerialized() {
+ SerializedThrowable serializedThrowable = new
SerializedThrowable(mockThrowable());
+ assertThat(serializedThrowable).isNotNull();
+ }
+
+ // Use the repeated test for checking the thread safe and stable.
+ @RepeatedTest(16)
Review Comment:
TBH, I prefer to not introduce such repeat tests since this increase the CI
time and resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
