lihaosky commented on code in PR #320:
URL: https://github.com/apache/flink-agents/pull/320#discussion_r2543992216
##########
plan/src/main/java/org/apache/flink/agents/plan/tools/SchemaUtils.java:
##########
@@ -61,7 +61,9 @@ public static String generateSchema(Method method) throws
JsonProcessingExceptio
}
Map<String, Object> paramSchema = getParamSchema(param);
- paramSchema.put("description", paramDescription);
+ if (paramDescription != null) {
Review Comment:
How can this be null? Looks `getParamSchema` at least returns `Map<String,
Object> paramSchema = new HashMap<>();`
##########
integrations/pom.xml:
##########
@@ -32,11 +32,12 @@ under the License.
<properties>
<ollama4j.version>1.1.2</ollama4j.version>
+ <openai.java.version>4.8.0</openai.java.version>
Review Comment:
```suggestion
<openai.version>4.8.0</openai.version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
