davidradl commented on code in PR #27251:
URL: https://github.com/apache/flink/pull/27251#discussion_r2541310829
##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/utils/ParserResource.java:
##########
@@ -34,6 +34,10 @@ public interface ParserResource {
@Resources.BaseMessage("OVERWRITE expression is only used with INSERT
statement.")
Resources.ExInst<ParseException> overwriteIsOnlyUsedWithInsert();
+ @Resources.BaseMessage(
+ "CREATE SYSTEM CONNECTION is not supported, system connection can
only be registered as temporary connection, you can use CREATE TEMPORARY SYSTEM
CONNECTION instead.")
+ Resources.ExInst<ParseException>
createSystemConnectionOnlySupportTemporary();
+
@Resources.BaseMessage(
"CREATE SYSTEM FUNCTION is not supported, system functions can
only be registered as temporary function, you can use CREATE TEMPORARY SYSTEM
FUNCTION instead.")
Review Comment:
nit: temporary function =-> temporary functions
##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/utils/ParserResource.java:
##########
@@ -34,6 +34,10 @@ public interface ParserResource {
@Resources.BaseMessage("OVERWRITE expression is only used with INSERT
statement.")
Resources.ExInst<ParseException> overwriteIsOnlyUsedWithInsert();
+ @Resources.BaseMessage(
+ "CREATE SYSTEM CONNECTION is not supported, system connection can
only be registered as temporary connection, you can use CREATE TEMPORARY SYSTEM
CONNECTION instead.")
+ Resources.ExInst<ParseException>
createSystemConnectionOnlySupportTemporary();
+
@Resources.BaseMessage(
"CREATE SYSTEM FUNCTION is not supported, system functions can
only be registered as temporary function, you can use CREATE TEMPORARY SYSTEM
FUNCTION instead.")
Review Comment:
nit: temporary function -> temporary functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
