bgeng777 commented on PR #27240: URL: https://github.com/apache/flink/pull/27240#issuecomment-3548050080
> @bgeng777 > > Great catch! This seems like a pretty obvious bug as the current implementation will _never_ evaluate correctly. My only feedback would be to ensure that we have tests to cover this (and potentially the other existing operations) as a logical change like this I'd have to imagine would break existing tests. hi @rionmonster, thanks for your comments. I would add some tests later. For your concern, I want to add more context: I have checked usage of the two classes and luckily `__le__` method is not used in current codes (When sorting `TimeWindow`, `__lt__` would be used which is correct). So the bug is not so critical and I make this PR a `hotfix` instead of a more normal JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
