[ 
https://issues.apache.org/jira/browse/FLINK-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822127#comment-15822127
 ] 

ASF GitHub Bot commented on FLINK-5485:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/3122

    [FLINK-5485] [webfrontend] Mark compiled web frontend files as binary when 
processed by git diff

    Particularly beneficial now that javascript is minified, we can mark 
compiled web frontend files as binary when processed by git diff.
      https://linux.die.net/man/5/gitattributes
    
    This does not affect how files are displayed by github.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 
5485_mark_compiled_web_frontend_files_as_binary_when_processed_by_git_diff

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3122
    
----
commit ace0272f9c3abc60645f2119744e88afa975a731
Author: Greg Hogan <c...@greghogan.com>
Date:   2017-01-13T18:33:29Z

    [FLINK-5485] [webfrontend] Mark compiled web frontend files as binary when 
processed by git diff
    
    Particularly beneficial now that javascript is minified, we can mark
    compiled web frontend files as binary when processed by git diff.
      https://linux.die.net/man/5/gitattributes
    
    This does not affect how files are displayed by github.

----


> Mark compiled web frontend files as binary when processed by git diff
> ---------------------------------------------------------------------
>
>                 Key: FLINK-5485
>                 URL: https://issues.apache.org/jira/browse/FLINK-5485
>             Project: Flink
>          Issue Type: Improvement
>          Components: Webfrontend
>    Affects Versions: 1.3.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Trivial
>             Fix For: 1.3.0
>
>
> Particularly beneficial now that javascript is minified, we can mark compiled 
> web frontend files as binary when processed by git diff.
>   https://linux.die.net/man/5/gitattributes
> This does not affect how files are displayed by github.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to