wenjin272 commented on code in PR #314:
URL: https://github.com/apache/flink-agents/pull/314#discussion_r2526417737
##########
python/flink_agents/api/prompts/prompt.py:
##########
@@ -22,10 +22,10 @@
from flink_agents.api.chat_message import ChatMessage, MessageRole
from flink_agents.api.prompts.utils import format_string
-from flink_agents.api.resource import ResourceType, SerializableResource
+from flink_agents.api.resource import Resource, ResourceType,
SerializableResource
-class Prompt(SerializableResource, ABC):
+class Prompt(Resource, ABC):
Review Comment:
+1 for this.
If this change is just to pass the serialization check of
`SerializableResource ` for `JavaPrompt`, you can annotate the `j_prompt`
ignored, like
```
class JavaPrompt(Prompt):
"""Python wrapper for Java's Prompt."""
j_prompt: Any = Field(exclude=True)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
