davidradl commented on code in PR #27199:
URL: https://github.com/apache/flink/pull/27199#discussion_r2498604894
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlMaterializedTableNodeToOperationConverterTest.java:
##########
@@ -490,7 +489,8 @@ void testAlterMaterializedTableAsQuery() throws
TableNotExistException {
.isEqualTo(newTable.getUnresolvedSchema().getPrimaryKey());
assertThat(oldTable.getUnresolvedSchema().getWatermarkSpecs())
.isEqualTo(newTable.getUnresolvedSchema().getWatermarkSpecs());
-
assertThat(oldTable.getDefinitionQuery()).isNotEqualTo(newTable.getDefinitionQuery());
Review Comment:
I am curious what you think, we have removed DefinitionQuery, but we still
have DefinitionFreshness. Should we rename DefinitionFreshness so it does not
include the word Definition - maybe change just to freshness to simplify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
