gong commented on code in PR #4169:
URL: https://github.com/apache/flink-cdc/pull/4169#discussion_r2493220531
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/assigner/StreamSplitAssigner.java:
##########
@@ -129,9 +129,11 @@ public void onFinishedSplits(Map<String, Offset>
splitFinishedOffsets) {
@Override
public void addSplits(Collection<SourceSplitBase> splits) {
Review Comment:
> Why not do it in addSplitsBack? If added back splits are empty, no need to
assign to both snapshot and stream split assinger.
Hi, @loserwang1024 I referred to mysql PR
https://github.com/apache/flink-cdc/pull/1627. Only stream mode have problem,
so modify streamSplitAssigner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
