lvyanquan commented on code in PR #27134:
URL: https://github.com/apache/flink/pull/27134#discussion_r2473477618
##########
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SinkV2ITCase.java:
##########
@@ -374,19 +374,19 @@ private void
assertUnalignedCheckpointInNonSink(StreamGraph streamGraph) {
IntegerTypeInfo.INT_TYPE_INFO);
}
- private static class BurstingRateLimiter implements RateLimiter {
- private final RateLimiter rateLimiter;
+ private static class BurstingRateLimiter implements RateLimiter<Void> {
+ private final RateLimiter<Void> rateLimiter;
private final int numCheckpointCooldown;
private int cooldown;
public BurstingRateLimiter(int recordPerCycle, int
numCheckpointCooldown) {
- rateLimiter = new GatedRateLimiter(recordPerCycle);
+ rateLimiter = new GatedRateLimiter<>(recordPerCycle);
this.numCheckpointCooldown = numCheckpointCooldown;
}
@Override
- public CompletionStage<Void> acquire() {
- CompletionStage<Void> stage = rateLimiter.acquire();
+ public CompletionStage<Void> acquire(int requestSize) {
Review Comment:
The returned `Future` here represents a single asynchronous execution
result, and there is no scenario where multiple `Future` instances are
returned. Therefore, the variable name `numberOfFutures` is not appropriate.
The input parameter here represents the number of requests, which could
specifically refer to the number (or even size) of data records. Since this
interface is not exclusively called by `SourceReader`, I used the more generic
term "Request" to abstract the concept beyond data-specific contexts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
