[
https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817935#comment-15817935
]
Fabian Hueske edited comment on FLINK-5256 at 1/11/17 10:36 AM:
----------------------------------------------------------------
Hi [~anmu],
I had a brief look over your branch and it looks much better. Definitely a big
step in the right direction.
I would like to continue the review on the PR. Can you update the pull request
(just push into the PR branch).
I think your test for the case of the empty input would not work. You would
still have one row as input but the cnt field would be null instead of the
actual count.
I think you can test this case by wrapping the {{SELECT COUNT(* ) AS cnt FROM
t2}} query in filter query: {{SELECT cnt FROM (SELECT COUNT(* ) AS cnt FROM t2)
WHERE cnt < 0}}.
Thanks, Fabian
was (Author: fhueske):
Hi [~anmu],
I had a brief look over your branch and it looks much better. Definitely a big
step in the right direction.
I would like to continue the review on the PR. Can you update the pull request
(just push into the PR branch).
One case that might be missing, is if the single row input is empty, i.e., if
the broadcasted values is null. In that case, the generated join function needs
to be called as well. I think you can test this case by wrapping the {{SELECT
COUNT(* ) AS cnt FROM t2}} query in filter query: {{SELECT cnt FROM (SELECT
COUNT(* ) AS cnt FROM t2) WHERE cnt < 0}}.
Thanks, Fabian
> Extend DataSetSingleRowJoin to support Left and Right joins
> -----------------------------------------------------------
>
> Key: FLINK-5256
> URL: https://issues.apache.org/jira/browse/FLINK-5256
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.2.0
> Reporter: Fabian Hueske
> Assignee: Anton Mushin
>
> The {{DataSetSingleRowJoin}} is a broadcast-map join that supports arbitrary
> inner joins where one input is a single row.
> I found that Calcite translates certain subqueries into non-equi left and
> right joins with single input. These cases can be handled if the
> {{DataSetSingleRowJoin}} is extended to support outer joins on the
> non-single-row input, i.e., left joins if the right side is single input and
> vice versa.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
