[ 
https://issues.apache.org/jira/browse/FLINK-4920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817887#comment-15817887
 ] 

ASF GitHub Bot commented on FLINK-4920:
---------------------------------------

Github user KurtYoung commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3080#discussion_r95548172
  
    --- Diff: 
flink-scala/src/test/scala/org/apache/flink/api/scala/metrics/ScalaGaugeTest.scala
 ---
    @@ -0,0 +1,48 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.scala.metrics
    +
    +import org.apache.flink.metrics.Gauge
    +import org.apache.flink.runtime.metrics.{MetricRegistry, 
MetricRegistryConfiguration}
    +import org.apache.flink.runtime.metrics.groups.GenericMetricGroup
    +import org.apache.flink.util.TestLogger
    +import org.junit.Test
    +import org.scalatest.junit.JUnitSuiteLike
    +
    +class ScalaGaugeTest extends TestLogger with JUnitSuiteLike {
    +
    +  @Test
    +  def testGaugeCorrectValue(): Unit = {
    +    val myGauge = ScalaGauge[Long]( () => 4 )
    +    assert( myGauge.getValue == 4 )
    --- End diff --
    
    same with the asserts, skip the spaces.


> Add a Scala Function Gauge
> --------------------------
>
>                 Key: FLINK-4920
>                 URL: https://issues.apache.org/jira/browse/FLINK-4920
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics, Scala API
>            Reporter: Stephan Ewen
>            Assignee: Pattarawat Chormai
>              Labels: easyfix, starter
>
> A useful metrics utility for the Scala API would be to add a Gauge that 
> obtains its value by calling a Scala Function0.
> That way, one can add Gauges in Scala programs using Scala lambda notation or 
> function references.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to