gaborgsomogyi commented on code in PR #26977:
URL: https://github.com/apache/flink/pull/26977#discussion_r2338978975
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java:
##########
@@ -955,13 +955,13 @@ boolean isCheckpointDiscard(long checkpointId) {
protected static class DirectoryHandleWithReferenceTrack {
private final DirectoryStreamStateHandle directoryHandle;
- // reference count by ongoing checkpoint
- private final AtomicLong ongoingRefCount;
+ // reference by ongoing checkpoint
+ private final Set<Long> refCheckpointIds;
private boolean tracking;
DirectoryHandleWithReferenceTrack(DirectoryStreamStateHandle
directoryHandle, boolean own) {
this.directoryHandle = directoryHandle;
- this.ongoingRefCount = new AtomicLong(0);
+ this.refCheckpointIds = new HashSet<>();
Review Comment:
Ah ok, so the original atomic was an extra here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
