loserwang1024 commented on code in PR #4113:
URL: https://github.com/apache/flink-cdc/pull/4113#discussion_r2320705697
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/fetch/PostgresSourceFetchTaskContext.java:
##########
@@ -148,8 +148,11 @@ public void configure(SourceSplitBase sourceSplitBase) {
dbzConfig
.getConfig()
.edit()
- // never drop slot for stream split, which
is also global split
- .with(DROP_SLOT_ON_STOP.name(), false)
+ // When startup.mode='snapshot' drop slot
for stream split,
+ // which is also global split
Review Comment:
I don't think so, If the job success to finish the stream split, it does no
need to restart. However, If fails before complete stream split, it means that
the job is not finished, and need to restart with checkpoint .
For batch mode, it has no checkpoint, thus no need to restart with
checkpont. But streaming job, it do need. @LYanquan , WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
