gustavodemorais commented on code in PR #26880:
URL: https://github.com/apache/flink/pull/26880#discussion_r2261674148
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalMultiJoin.java:
##########
@@ -194,26 +194,27 @@ private RexNode createMultiJoinCondition() {
return RexUtil.composeConjunction(getCluster().getRexBuilder(),
conjunctions, true);
}
- private List<List<int[]>> getUpsertKeysForInputs() {
+ private List<List<int[]>> getUniqueKeysForInputs() {
return inputs.stream()
.map(
input -> {
- final Set<ImmutableBitSet> upsertKeys =
getUpsertKeys(input);
+ final Set<ImmutableBitSet> uniqueKeys =
getUniqueKeys(input);
- if (upsertKeys == null) {
+ if (uniqueKeys == null) {
return Collections.<int[]>emptyList();
}
- return upsertKeys.stream()
+
+ return uniqueKeys.stream()
.map(ImmutableBitSet::toArray)
.collect(Collectors.toList());
})
.collect(Collectors.toList());
}
- private @Nullable Set<ImmutableBitSet> getUpsertKeys(RelNode input) {
+ private @Nullable Set<ImmutableBitSet> getUniqueKeys(RelNode input) {
final FlinkRelMetadataQuery fmq =
FlinkRelMetadataQuery.reuseOrCreate(input.getCluster().getMetadataQuery());
- return fmq.getUpsertKeys(input);
+ return fmq.getUniqueKeys(input);
Review Comment:
Added MULTI_JOIN_MIXED_CHANGELOG_MODES
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
