davidradl commented on code in PR #26727:
URL: https://github.com/apache/flink/pull/26727#discussion_r2175004943
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/lineage/TableLineageDatasetImpl.java:
##########
@@ -49,8 +48,7 @@ public TableLineageDatasetImpl(
this.catalogContext =
CatalogContext.createContext(
contextResolvedTable.getCatalog().isPresent()
- ? ((AbstractCatalog)
contextResolvedTable.getCatalog().get())
- .getName()
+ ?
contextResolvedTable.getIdentifier().getCatalogName()
Review Comment:
I see that this
[call](https://github.com/apache/flink/blob/49c28f7e4bc37a9196880a6727605572476fe6a9/flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ObjectIdentifier.java#L89)
can return UNKNOWN and the catalogName is nullable in ObjectIdentifier. In
this case shouldn't we set this parameter to "".
It would be worth adding a unit test when there is an Objectidentifier
without a catalogName to ensure this case is handled properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
