sjmudd commented on code in PR #3666:
URL: https://github.com/apache/flink-cdc/pull/3666#discussion_r2159334603
##########
.github/workflows/flink_cdc.yml:
##########
@@ -61,7 +61,7 @@ jobs:
strategy:
matrix:
java-version: [ '8' ]
- module: [ 'core', 'pipeline_connectors', 'mysql', 'postgres',
'oracle', 'mongodb6', 'mongodb7', 'sqlserver', 'tidb', 'oceanbase', 'db2',
'vitess' ]
+ module: [ 'core', 'pipeline_connectors', 'mysql57', 'mysql80',
'mysql84', 'mysql90', 'postgres', 'oracle', 'mongodb6', 'mongodb7',
'sqlserver', 'tidb', 'oceanbase', 'db2', 'vitess' ]
Review Comment:
Do not use 'mysql90" as a label. Oracle has horrible versioning and
basically you probably need to do one of the following: label as "mysql9x" as
9.X.0 changes every 3 months until it's expected to be 9.7 LTS in April 2026
and then numbers become normal again. e.g. expected to be 9.7.0, 9.7.1, ...
Basically 9.0 should not be used 9.3.0 is current innovation release and
it'll be 9.4.0 on ~15th July. So until 9.X is confirmed to be LTS either don't
mention it or label it 'mysql9x'.
Reference:
https://dev.mysql.com/blog-archive/introducing-mysql-innovation-and-long-term-support-lts-versions/
Clearly do what makes sense but 'mysql90' will never be a useful label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
